feat(autofix): Fix additional deprecated Core APIs #639

maxreichmann · 2025-04-24T15:50:29Z

JIRA: CPOUI5FOUNDATION-991

Enhances #671 by enabling more complex autofixes where migration depends on the provided arguments.

Resolves partially: #619

Follow up PRs:
#675

test/fixtures/autofix/coreApi/DeprecatedCoreApi.js

test/fixtures/autofix/coreApi/DeprecatedCoreApi.fixed.js

test/fixtures/autofix/coreApi/DeprecatedCoreApi.js

src/linter/ui5Types/fixHints/CoreFixHintsGenerator.ts

src/autofix/solutions/codeReplacer.ts

src/linter/ui5Types/fixHints/CoreFixHintsGenerator.ts

src/linter/ui5Types/TypeLinter.ts

test/fixtures/autofix/coreApi/DeprecatedCoreApi.fixed.js

matz3 · 2025-05-27T09:07:25Z

test/fixtures/linter/projects/library.with.custom.paths/src/main/js/Example.js

 	"use strict";
+
+	sap.ui.getCore().getLibraryResourceBundle("library.with.custom.paths", "en_US");


This is currently not fixed, but it should be, right?

Will be resolved with: #675

test/fixtures/linter/projects/library.with.custom.paths/src/main/js/Example.js

test/lib/autofix/snapshots/autofix.fixtures.ts.md

matz3 · 2025-05-27T09:25:10Z

src/autofix/solutions/codeReplacer.ts

 	}

 	return fixHints;
 }

+function extractKeyValuePairs(jsonLikeStr: string) {


We already have the relevant information accessible via AST nodes, so I don't think we should parse the argument ourselves here. The input is based on node.getText(). We even have already code that can analyze object structures, which is used for certain checks in SourceFileLinter.

Will be resolved in #675

matz3 · 2025-05-27T11:10:48Z

src/autofix/solutions/codeReplacer.ts

+					name: fixHints.exportCodeToBeUsed.args[0].value.replace(/^['"]+|['"]+$/g, ""),
+					url: libOptionsExpression.url,
+				};
+				fixHints.exportCodeToBeUsed.args[0].value = JSON.stringify(newArg);


Here the comments in the code get lost. Also, the used quotes in the code will be always replaced by double-quotes.

Will be resolved in #675

matz3 · 2025-05-27T11:12:23Z

src/autofix/solutions/codeReplacer.ts

+				extractKeyValuePairs(fixHints.exportCodeToBeUsed.args[1].value) as {async: boolean; url?: string};
+			if (libOptionsExpression.async === true) {
+				const newArg = {
+					name: fixHints.exportCodeToBeUsed.args[0].value.replace(/^['"]+|['"]+$/g, ""),


Using back-ticks as first arg (library name) results into quoted backticks.

Will be resolved in #675

matz3

LGTM

Issues were addressed

RandomByte

LGTM

maxreichmann force-pushed the autofix-deprecated-core-apis branch 4 times, most recently from 7c8c5bc to bb20759 Compare April 29, 2025 09:34

RandomByte previously requested changes May 12, 2025

View reviewed changes

d3xter666 force-pushed the autofix-deprecated-core-apis branch 2 times, most recently from fc44eab to 5fa49bb Compare May 15, 2025 08:06

maxreichmann commented May 16, 2025

View reviewed changes

src/linter/ui5Types/fixHints/CoreFixHintsGenerator.ts Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems May 20, 2025

View reviewed changes

src/autofix/solutions/codeReplacer.ts Fixed Show fixed Hide fixed

matz3 reviewed May 26, 2025

View reviewed changes

src/linter/ui5Types/fixHints/CoreFixHintsGenerator.ts Outdated Show resolved Hide resolved

src/linter/ui5Types/fixHints/CoreFixHintsGenerator.ts Outdated Show resolved Hide resolved

src/linter/ui5Types/fixHints/CoreFixHintsGenerator.ts Outdated Show resolved Hide resolved

d3xter666 marked this pull request as ready for review May 27, 2025 08:48

d3xter666 requested a review from a team May 27, 2025 08:48

matz3 reviewed May 27, 2025

View reviewed changes

d3xter666 changed the base branch from main to autofix-deprecated-core-base May 27, 2025 12:57

d3xter666 force-pushed the autofix-deprecated-core-apis branch from 43442c9 to 756264a Compare May 27, 2025 13:07

d3xter666 force-pushed the autofix-deprecated-core-base branch from d0120ff to b272a5a Compare May 27, 2025 14:12

d3xter666 force-pushed the autofix-deprecated-core-apis branch from 756264a to cbc6e6a Compare May 27, 2025 14:23

d3xter666 marked this pull request as draft May 28, 2025 07:00

d3xter666 force-pushed the autofix-deprecated-core-apis branch 2 times, most recently from 0c07e32 to cb85a25 Compare May 28, 2025 07:46

This was referenced May 28, 2025

feat(autofix): Fix basic deprecated Core APIs #671

Merged

feat: Autofix Core API (complex cases) #675

Draft

d3xter666 force-pushed the autofix-deprecated-core-base branch from 8372914 to 79ea741 Compare May 28, 2025 11:07

d3xter666 force-pushed the autofix-deprecated-core-apis branch 3 times, most recently from f033503 to 0b46e18 Compare May 29, 2025 07:12

d3xter666 marked this pull request as ready for review May 29, 2025 08:25

d3xter666 requested a review from a team May 30, 2025 06:34

d3xter666 added 18 commits June 2, 2025 14:19

refactor: Do not migrate unknown lib names

06a72a1

test: Update snapshots

c5a0fe9

feat: Detect libs from manifest.json

baafedc

feat: Detect lib namespace

13b147e

fix: Use modules, not globals

090971e

test: Update snapshots

70df1ed

fix: Resolve merge conflicts

504f923

fix: Rebase conflicts

d5b1134

refactor: Cleanups

9d4d11b

refactor: Remove redundant code

bf21c66

fix: Update snapshots

cc792c0

test: Remove redundant code

d82460b

test: Update snapshots

7807eb5

fix: Resolve merge conflicts

5e285f8

fix: Resolve value of getActiveElement()

ccf7bf2

refactor: Postpone migration of loadLibrary & createComponent

2d0e904

refactor: Cleanups

e9da582

test: Remove not migrated test cases

1eafe45

d3xter666 force-pushed the autofix-deprecated-core-apis branch from c815258 to 1eafe45 Compare June 2, 2025 11:22

d3xter666 changed the title ~~feat: Offer autofix for deprecated Core APIs~~ feat(autofix): Fix deprecated Core APIs Jun 2, 2025

d3xter666 requested review from RandomByte and matz3 June 2, 2025 13:27

matz3 reviewed Jun 3, 2025

View reviewed changes

RandomByte changed the title ~~feat(autofix): Fix deprecated Core APIs~~ feat(autofix): Fix additional deprecated Core APIs Jun 5, 2025

RandomByte reviewed Jun 5, 2025

View reviewed changes

matz3 approved these changes Jun 5, 2025

View reviewed changes

d3xter666 merged commit af2cb9b into main Jun 5, 2025
22 checks passed

d3xter666 deleted the autofix-deprecated-core-apis branch June 5, 2025 12:08

openui5bot mentioned this pull request Jun 5, 2025

release: v1.14.0 #658

Open

		"use strict";

		sap.ui.getCore().getLibraryResourceBundle("library.with.custom.paths", "en_US");

feat(autofix): Fix additional deprecated Core APIs #639

feat(autofix): Fix additional deprecated Core APIs #639

Uh oh!

Conversation

maxreichmann commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matz3 left a comment

Choose a reason for hiding this comment

Uh oh!

RandomByte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

maxreichmann commented Apr 24, 2025 •

edited

Loading